summaryrefslogtreecommitdiff
path: root/include/linux/fsnotify.h
diff options
context:
space:
mode:
authorAmir Goldstein <amir73il@gmail.com>2019-05-26 17:34:10 +0300
committerJan Kara <jack@suse.cz>2019-06-20 15:47:44 +0300
commit49246466a98996e78b68a0041807dbd2628c53fe (patch)
tree67fe8d0ed3353e9933b886d11a10ea07bb1d3f22 /include/linux/fsnotify.h
parent6146e78c0364a881af9bec42eb40882b1e329327 (diff)
downloadlinux-49246466a98996e78b68a0041807dbd2628c53fe.tar.xz
fsnotify: move fsnotify_nameremove() hook out of d_delete()
d_delete() was piggy backed for the fsnotify_nameremove() hook when in fact not all callers of d_delete() care about fsnotify events. For all callers of d_delete() that may be interested in fsnotify events, we made sure to call one of fsnotify_{unlink,rmdir}() hooks before calling d_delete(). Now we can move the fsnotify_nameremove() call from d_delete() to the fsnotify_{unlink,rmdir}() hooks. Two explicit calls to fsnotify_nameremove() from nfs/afs sillyrename are also removed. This will cause a change of behavior - nfs/afs will NOT generate an fsnotify delete event when renaming over a positive dentry. This change is desirable, because it is consistent with the behavior of all other filesystems. Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'include/linux/fsnotify.h')
-rw-r--r--include/linux/fsnotify.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/include/linux/fsnotify.h b/include/linux/fsnotify.h
index 7f23eddefcd0..0145073c2b42 100644
--- a/include/linux/fsnotify.h
+++ b/include/linux/fsnotify.h
@@ -199,6 +199,7 @@ static inline void fsnotify_unlink(struct inode *dir, struct dentry *dentry)
WARN_ON_ONCE(d_is_negative(dentry));
/* TODO: call fsnotify_dirent() */
+ fsnotify_nameremove(dentry, 0);
}
/*
@@ -222,6 +223,7 @@ static inline void fsnotify_rmdir(struct inode *dir, struct dentry *dentry)
WARN_ON_ONCE(d_is_negative(dentry));
/* TODO: call fsnotify_dirent() */
+ fsnotify_nameremove(dentry, 1);
}
/*