summaryrefslogtreecommitdiff
path: root/include/linux/mtd
diff options
context:
space:
mode:
authorOleksandr Ocheretnyi <oocheret@cisco.com>2022-04-17 21:46:47 +0300
committerMiquel Raynal <miquel.raynal@bootlin.com>2022-04-21 10:29:05 +0300
commit37c5f9e80e015d0df17d0c377c18523002986851 (patch)
tree266f266ba5b26bff162dbaead07552e0fd3f2772 /include/linux/mtd
parent084c16ab423a8890121b902b405823bfec5b4365 (diff)
downloadlinux-37c5f9e80e015d0df17d0c377c18523002986851.tar.xz
mtd: fix 'part' field data corruption in mtd_info
Commit 46b5889cc2c5 ("mtd: implement proper partition handling") started using "mtd_get_master_ofs()" in mtd callbacks to determine memory offsets by means of 'part' field from mtd_info, what previously was smashed accessing 'master' field in the mtd_set_dev_defaults() method. That provides wrong offset what causes hardware access errors. Just make 'part', 'master' as separate fields, rather than using union type to avoid 'part' data corruption when mtd_set_dev_defaults() is called. Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling") Signed-off-by: Oleksandr Ocheretnyi <oocheret@cisco.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20220417184649.449289-1-oocheret@cisco.com
Diffstat (limited to 'include/linux/mtd')
-rw-r--r--include/linux/mtd/mtd.h6
1 files changed, 2 insertions, 4 deletions
diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 151607e9d64a..955aee14b0f7 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -389,10 +389,8 @@ struct mtd_info {
/* List of partitions attached to this MTD device */
struct list_head partitions;
- union {
- struct mtd_part part;
- struct mtd_master master;
- };
+ struct mtd_part part;
+ struct mtd_master master;
};
static inline struct mtd_info *mtd_get_master(struct mtd_info *mtd)