summaryrefslogtreecommitdiff
path: root/include/scsi
diff options
context:
space:
mode:
authorHannes Reinecke <hare@suse.de>2021-04-27 11:30:12 +0300
committerMartin K. Petersen <martin.petersen@oracle.com>2021-06-01 05:48:21 +0300
commitced202f7bd78eb6a79c441a8b217e0f3d38bccfc (patch)
treea1f7fc246edf2ab038685b64540ce53392b145a6 /include/scsi
parent7e26e3ea028740f934477ec01ba586ab033c35aa (diff)
downloadlinux-ced202f7bd78eb6a79c441a8b217e0f3d38bccfc.tar.xz
scsi: core: Stop using DRIVER_ERROR
Return the actual error code in __scsi_execute() (which, according to the documentation, should have happened anyway). And audit all callers to cope with negative return values from __scsi_execute() and friends. [mkp: resolve conflict and return bool] Link: https://lore.kernel.org/r/20210427083046.31620-7-hare@suse.de Reviewed-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'include/scsi')
-rw-r--r--include/scsi/scsi.h7
1 files changed, 5 insertions, 2 deletions
diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
index 7f392405991b..6dc2d1b3735e 100644
--- a/include/scsi/scsi.h
+++ b/include/scsi/scsi.h
@@ -259,10 +259,13 @@ enum scsi_disposition {
* This returns true for known good conditions that may be treated as
* command completed normally
*/
-static inline int scsi_status_is_good(int status)
+static inline bool scsi_status_is_good(int status)
{
+ if (status < 0)
+ return false;
+
if (host_byte(status) == DID_NO_CONNECT)
- return 0;
+ return false;
/*
* FIXME: bit0 is listed as reserved in SCSI-2, but is