diff options
author | Gergo Koteles <soyer@irl.hu> | 2024-02-04 23:01:17 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-02-23 11:25:14 +0300 |
commit | eb06fca2c740b49f836a2fc3068ec27b051fd7c5 (patch) | |
tree | 56da6f5dd53cf20df73dfd8bc1e58849a63d2894 /include/sound | |
parent | 1be2669565b3795e2a1e2b97adb059410d8d8d53 (diff) | |
download | linux-eb06fca2c740b49f836a2fc3068ec27b051fd7c5.tar.xz |
ASoC: tas2781: add module parameter to tascodec_init()
commit 34a1066981a967eab619938e7b35a9be6b4c34e1 upstream.
The tascodec_init() of the snd-soc-tas2781-comlib module is called from
snd-soc-tas2781-i2c and snd-hda-scodec-tas2781-i2c modules. It calls
request_firmware_nowait() with parameter THIS_MODULE and a cont/callback
from the latter modules.
The latter modules can be removed while their callbacks are running,
resulting in a general protection failure.
Add module parameter to tascodec_init() so request_firmware_nowait() can
be called with the module of the callback.
Fixes: ef3bcde75d06 ("ASoC: tas2781: Add tas2781 driver")
CC: stable@vger.kernel.org
Signed-off-by: Gergo Koteles <soyer@irl.hu>
Link: https://lore.kernel.org/r/118dad922cef50525e5aab09badef2fa0eb796e5.1707076603.git.soyer@irl.hu
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/sound')
-rw-r--r-- | include/sound/tas2781.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/sound/tas2781.h b/include/sound/tas2781.h index a6c808b22318..475294c853aa 100644 --- a/include/sound/tas2781.h +++ b/include/sound/tas2781.h @@ -135,6 +135,7 @@ struct tasdevice_priv { void tas2781_reset(struct tasdevice_priv *tas_dev); int tascodec_init(struct tasdevice_priv *tas_priv, void *codec, + struct module *module, void (*cont)(const struct firmware *fw, void *context)); struct tasdevice_priv *tasdevice_kzalloc(struct i2c_client *i2c); int tasdevice_init(struct tasdevice_priv *tas_priv); |