summaryrefslogtreecommitdiff
path: root/include/target/iscsi
diff options
context:
space:
mode:
authorAndy Grover <agrover@redhat.com>2015-08-24 20:26:03 +0300
committerNicholas Bellinger <nab@linux-iscsi.org>2015-08-27 09:27:09 +0300
commit76c28f1fcfeb42b47f798fe498351ee1d60086ae (patch)
tree14e0a895f308f1bbf90075b080948e942320647c /include/target/iscsi
parent109e2381749c1cfd94a0d22b2b54142539024973 (diff)
downloadlinux-76c28f1fcfeb42b47f798fe498351ee1d60086ae.tar.xz
target/iscsi: Fix np_ip bracket issue by removing np_ip
Revert commit 1997e6259, which causes double brackets on ipv6 inaddr_any addresses. Since we have np_sockaddr, if we need a textual representation we can use "%pISc". Change iscsit_add_network_portal() and iscsit_add_np() signatures to remove *ip_str parameter. Fix and extend some comments earlier in the function. Tested to work for :: and ::1 via iscsiadm, previously :: failed, see https://bugzilla.redhat.com/show_bug.cgi?id=1249107 . CC: stable@vger.kernel.org Signed-off-by: Andy Grover <agrover@redhat.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'include/target/iscsi')
-rw-r--r--include/target/iscsi/iscsi_target_core.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/include/target/iscsi/iscsi_target_core.h b/include/target/iscsi/iscsi_target_core.h
index d4616ef12e04..1051d0c40ddd 100644
--- a/include/target/iscsi/iscsi_target_core.h
+++ b/include/target/iscsi/iscsi_target_core.h
@@ -778,7 +778,6 @@ struct iscsi_np {
enum iscsi_timer_flags_table np_login_timer_flags;
u32 np_exports;
enum np_flags_table np_flags;
- unsigned char np_ip[IPV6_ADDRESS_SPACE];
u16 np_port;
spinlock_t np_thread_lock;
struct completion np_restart_comp;