diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2023-08-03 12:59:28 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-09-19 13:20:08 +0300 |
| commit | 625bf86bf53eb7a8ee60fb9dc45b272b77e5ce1c (patch) | |
| tree | 78637f73bac47a854537542a1cd4c7986e9b34d1 /include | |
| parent | 7545292d87db4b32004e6fb5be0bbaaba46a45c0 (diff) | |
| download | linux-625bf86bf53eb7a8ee60fb9dc45b272b77e5ce1c.tar.xz | |
crypto: api - Use work queue in crypto_destroy_instance
[ Upstream commit 9ae4577bc077a7e32c3c7d442c95bc76865c0f17 ]
The function crypto_drop_spawn expects to be called in process
context. However, when an instance is unregistered while it still
has active users, the last user may cause the instance to be freed
in atomic context.
Fix this by delaying the freeing to a work queue.
Fixes: 6bfd48096ff8 ("[CRYPTO] api: Added spawns")
Reported-by: Florent Revest <revest@chromium.org>
Reported-by: syzbot+d769eed29cc42d75e2a3@syzkaller.appspotmail.com
Reported-by: syzbot+610ec0671f51e838436e@syzkaller.appspotmail.com
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Tested-by: Florent Revest <revest@chromium.org>
Acked-by: Florent Revest <revest@chromium.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/crypto/algapi.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/crypto/algapi.h b/include/crypto/algapi.h index 18dd7a4aaf7d..96dbd438cc70 100644 --- a/include/crypto/algapi.h +++ b/include/crypto/algapi.h @@ -10,6 +10,7 @@ #include <linux/crypto.h> #include <linux/list.h> #include <linux/kernel.h> +#include <linux/workqueue.h> /* * Maximum values for blocksize and alignmask, used to allocate @@ -55,6 +56,8 @@ struct crypto_instance { struct crypto_spawn *spawns; }; + struct work_struct free_work; + void *__ctx[] CRYPTO_MINALIGN_ATTR; }; |