diff options
author | Jiri Pirko <jiri@nvidia.com> | 2023-01-18 18:21:06 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2023-01-20 06:08:37 +0300 |
commit | ee75f1fc44dd73f0323118f31cf91f9b6db147fa (patch) | |
tree | ce976feaa6c056c01af12b0ea4848c97a3a9d21a /include | |
parent | 3a10173f48aa1bae64baf0fea228c6045996b117 (diff) | |
download | linux-ee75f1fc44dd73f0323118f31cf91f9b6db147fa.tar.xz |
net/mlx5e: Create separate devlink instance for ethernet auxiliary device
The fact that devlink instance lock is held over mlx5 auxiliary devices
probe and remove routines brought a need to conditionally take devlink
instance lock there. The code is checking a MLX5E_LOCKED_FLOW flag
in mlx5 priv struct.
This is racy and may lead to access devlink objects without holding
instance lock or deadlock.
To avoid this, the only lock-wise sane solution is to make the
devlink entities created by the auxiliary device independent on
the original pci devlink instance. Create devlink instance for the
auxiliary device and put the uplink port instance there alongside with
the port health reporters.
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions