summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorMichael Walle <michael@walle.cc>2023-03-10 12:48:45 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-03-10 12:55:49 +0300
commit06be62083c5308c76a891ca975d66d832e2afc07 (patch)
tree90b9cc5e4c5bcaee9478473c51c83dcb98c79edd /include
parent38ed310c22e7a0fc978b1f8292136a4a4a8b3051 (diff)
downloadlinux-06be62083c5308c76a891ca975d66d832e2afc07.tar.xz
nvmem: core: return -ENOENT if nvmem cell is not found
Prior to commit 5d8e6e6c10a3 ("nvmem: core: add an index parameter to the cell") of_nvmem_cell_get() would return -ENOENT if the cell wasn't found. Particularly, if of_property_match_string() returned -EINVAL, that return code was passed as the index to of_parse_phandle(), which then detected it as invalid and returned NULL. That led to an return code of -ENOENT. With the new code, the negative index will lead to an -EINVAL of of_parse_phandle_with_optional_args() which pass straight to the caller and break those who expect an -ENOENT. Fix it by always returning -ENOENT. Fixes: 5d8e6e6c10a3 ("nvmem: core: add an index parameter to the cell") Reported-by: Alexander Stein <alexander.stein@ew.tq-group.com> Link: https://lore.kernel.org/r/2143916.GUh0CODmnK@steina-w/ Signed-off-by: Michael Walle <michael@walle.cc> Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Link: https://lore.kernel.org/r/20230310094845.139400-1-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions