diff options
author | David Howells <dhowells@redhat.com> | 2020-10-28 15:08:39 +0300 |
---|---|---|
committer | David Howells <dhowells@redhat.com> | 2020-10-29 16:53:04 +0300 |
commit | 2d9900f26ad61e63a34f239bc76c80d2f8a6ff41 (patch) | |
tree | 6c0954fab4d0adeb6797ade360a28ff0e42c23af /include | |
parent | f86726a69dec5df6ba051baf9265584419478b64 (diff) | |
download | linux-2d9900f26ad61e63a34f239bc76c80d2f8a6ff41.tar.xz |
afs: Fix dirty-region encoding on ppc32 with 64K pages
The dirty region bounds stored in page->private on an afs page are 15 bits
on a 32-bit box and can, at most, represent a range of up to 32K within a
32K page with a resolution of 1 byte. This is a problem for powerpc32 with
64K pages enabled.
Further, transparent huge pages may get up to 2M, which will be a problem
for the afs filesystem on all 32-bit arches in the future.
Fix this by decreasing the resolution. For the moment, a 64K page will
have a resolution determined from PAGE_SIZE. In the future, the page will
need to be passed in to the helper functions so that the page size can be
assessed and the resolution determined dynamically.
Note that this might not be the ideal way to handle this, since it may
allow some leakage of undirtied zero bytes to the server's copy in the case
of a 3rd-party conflict. Fixing that would require a separately allocated
record and is a more complicated fix.
Fixes: 4343d00872e1 ("afs: Get rid of the afs_writeback record")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions