summaryrefslogtreecommitdiff
path: root/init
diff options
context:
space:
mode:
authorDamien Le Moal <damien.lemoal@opensource.wdc.com>2023-01-06 11:43:06 +0300
committerDamien Le Moal <damien.lemoal@opensource.wdc.com>2023-01-16 02:42:12 +0300
commita608da3bd730d718f2d3ebec1c26f9865f8f17ce (patch)
tree1d05e7fd09e4da159398e874d3f010909083b5b2 /init
parent5dc4c995db9eb45f6373a956eb1f69460e69e6d4 (diff)
downloadlinux-a608da3bd730d718f2d3ebec1c26f9865f8f17ce.tar.xz
zonefs: Detect append writes at invalid locations
Using REQ_OP_ZONE_APPEND operations for synchronous writes to sequential files succeeds regardless of the zone write pointer position, as long as the target zone is not full. This means that if an external (buggy) application writes to the zone of a sequential file underneath the file system, subsequent file write() operation will succeed but the file size will not be correct and the file will contain invalid data written by another application. Modify zonefs_file_dio_append() to check the written sector of an append write (returned in bio->bi_iter.bi_sector) and return -EIO if there is a mismatch with the file zone wp offset field. This change triggers a call to zonefs_io_error() and a zone check. Modify zonefs_io_error_cb() to not expose the unexpected data after the current inode size when the errors=remount-ro mode is used. Other error modes are correctly handled already. Fixes: 02ef12a663c7 ("zonefs: use REQ_OP_ZONE_APPEND for sync DIO") Cc: stable@vger.kernel.org Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions