summaryrefslogtreecommitdiff
path: root/io_uring/advise.c
diff options
context:
space:
mode:
authorDylan Yudaken <dylany@meta.com>2023-01-27 16:52:25 +0300
committerJens Axboe <axboe@kernel.dk>2023-01-30 01:18:26 +0300
commitaebb224fd4fc7352cd839ad90414c548387142fd (patch)
tree8f209de8d9e8eec51774f27764dd5229d0a2d463 /io_uring/advise.c
parent6bb30855560e6343e7b88595d7c3159d0f848a04 (diff)
downloadlinux-aebb224fd4fc7352cd839ad90414c548387142fd.tar.xz
io_uring: for requests that require async, force it
Some requests require being run async as they do not support non-blocking. Instead of trying to issue these requests, getting -EAGAIN and then queueing them for async issue, rather just force async upfront. Add WARN_ON_ONCE to make sure surprising code paths do not come up, however in those cases the bug would end up being a blocking io_uring_enter(2) which should not be critical. Signed-off-by: Dylan Yudaken <dylany@meta.com> Link: https://lore.kernel.org/r/20230127135227.3646353-3-dylany@meta.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'io_uring/advise.c')
-rw-r--r--io_uring/advise.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/io_uring/advise.c b/io_uring/advise.c
index 449c6f14649f..cf600579bffe 100644
--- a/io_uring/advise.c
+++ b/io_uring/advise.c
@@ -39,6 +39,7 @@ int io_madvise_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
ma->addr = READ_ONCE(sqe->addr);
ma->len = READ_ONCE(sqe->len);
ma->advice = READ_ONCE(sqe->fadvise_advice);
+ req->flags |= REQ_F_FORCE_ASYNC;
return 0;
#else
return -EOPNOTSUPP;
@@ -51,8 +52,7 @@ int io_madvise(struct io_kiocb *req, unsigned int issue_flags)
struct io_madvise *ma = io_kiocb_to_cmd(req, struct io_madvise);
int ret;
- if (issue_flags & IO_URING_F_NONBLOCK)
- return -EAGAIN;
+ WARN_ON_ONCE(issue_flags & IO_URING_F_NONBLOCK);
ret = do_madvise(current->mm, ma->addr, ma->len, ma->advice);
io_req_set_res(req, ret, 0);