diff options
author | Eric Biggers <ebiggers@google.com> | 2020-10-31 03:45:56 +0300 |
---|---|---|
committer | Eric Biggers <ebiggers@google.com> | 2020-11-06 20:48:55 +0300 |
commit | 92cfcd030e4b1de11a6b1edb0840e55c26332d31 (patch) | |
tree | 73b98ccd1c786537e0455cd239503a0871d545f1 /ipc | |
parent | 3cea11cd5e3b00d91caf0b4730194039b45c5891 (diff) | |
download | linux-92cfcd030e4b1de11a6b1edb0840e55c26332d31.tar.xz |
fscrypt: remove reachable WARN in fscrypt_setup_iv_ino_lblk_32_key()
I_CREATING isn't actually set until the inode has been assigned an inode
number and inserted into the inode hash table. So the WARN_ON() in
fscrypt_setup_iv_ino_lblk_32_key() is wrong, and it can trigger when
creating an encrypted file on ext4. Remove it.
This was sometimes causing xfstest generic/602 to fail on ext4. I
didn't notice it before because due to a separate oversight, new inodes
that haven't been assigned an inode number yet don't necessarily have
i_ino == 0 as I had thought, so by chance I never saw the test fail.
Fixes: a992b20cd4ee ("fscrypt: add fscrypt_prepare_new_inode() and fscrypt_set_context()")
Reported-by: Theodore Y. Ts'o <tytso@mit.edu>
Link: https://lore.kernel.org/r/20201031004556.87862-1-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Diffstat (limited to 'ipc')
0 files changed, 0 insertions, 0 deletions