diff options
| author | Alexey Dobriyan <adobriyan@gmail.com> | 2020-12-16 07:44:00 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-06-21 16:45:35 +0300 |
| commit | c2def5578b440f6ac45fcffcf766d968d7c3bea5 (patch) | |
| tree | ed59b95b6ae59177f308aca7f790f3617c04cf8b /lib/test_firmware.c | |
| parent | a1f0beb13d9b8955e00caa48f909462fb70e6f73 (diff) | |
| download | linux-c2def5578b440f6ac45fcffcf766d968d7c3bea5.tar.xz | |
lib: cleanup kstrto*() usage
[ Upstream commit 506dfc9906e5cbf453bbcd5eb627689435583558 ]
Use proper conversion functions. kstrto*() variants exist for all
standard types.
Link: https://lkml.kernel.org/r/20201122123410.GB92364@localhost.localdomain
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Stable-dep-of: 4acfe3dfde68 ("test_firmware: prevent race conditions by a correct implementation of locking")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'lib/test_firmware.c')
| -rw-r--r-- | lib/test_firmware.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/lib/test_firmware.c b/lib/test_firmware.c index 581ee3fcdd5c..3edbc17d92db 100644 --- a/lib/test_firmware.c +++ b/lib/test_firmware.c @@ -371,18 +371,15 @@ static ssize_t test_dev_config_show_int(char *buf, int val) static int test_dev_config_update_u8(const char *buf, size_t size, u8 *cfg) { + u8 val; int ret; - long new; - ret = kstrtol(buf, 10, &new); + ret = kstrtou8(buf, 10, &val); if (ret) return ret; - if (new > U8_MAX) - return -EINVAL; - mutex_lock(&test_fw_mutex); - *(u8 *)cfg = new; + *(u8 *)cfg = val; mutex_unlock(&test_fw_mutex); /* Always return full write size even if we didn't consume all */ |