summaryrefslogtreecommitdiff
path: root/lib/test_objagg.c
diff options
context:
space:
mode:
authorBartosz Golaszewski <bgolaszewski@baylibre.com>2020-06-11 17:01:39 +0300
committerDavid S. Miller <davem@davemloft.net>2020-06-15 23:30:58 +0300
commitadaff6d906d74dfe34d44fd18d5a7596d293df44 (patch)
tree4e157af09d2e292c7612a51fe3f9504002738016 /lib/test_objagg.c
parentea2fce88d2fd678ed9d45354ff49b73f1d5615dd (diff)
downloadlinux-adaff6d906d74dfe34d44fd18d5a7596d293df44.tar.xz
net: ethernet: mtk-star-emac: simplify interrupt handling
During development we tried to make the interrupt handling as fine-grained as possible with TX and RX interrupts being disabled/enabled independently and the counter registers reset from workqueue context. Unfortunately after thorough testing of current mainline, we noticed the driver has become unstable under heavy load. While this is hard to reproduce, it's quite consistent in the driver's current form. This patch proposes to go back to the previous approach of doing all processing in napi context with all interrupts masked in order to make the driver usable in mainline linux. This doesn't impact the performance on pumpkin boards at all and it's in line with what many ethernet drivers do in mainline linux anyway. At the same time we're adding a FIXME comment about the need to improve the interrupt handling. Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver") Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib/test_objagg.c')
0 files changed, 0 insertions, 0 deletions