diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-02-23 17:20:13 +0300 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2024-03-27 01:17:17 +0300 |
| commit | 7f71a28b0a17ade767c8ff016433d89c4654d305 (patch) | |
| tree | fcfbec433efda640f7885d53d920dc3667cef579 /lib | |
| parent | 533fabf94c2e90aeeff046c0b463e3ff2eadaf0a (diff) | |
| download | linux-7f71a28b0a17ade767c8ff016433d89c4654d305.tar.xz | |
lib/stackdepot: off by one in depot_fetch_stack()
[ Upstream commit dc24559472a682eb124e869cb110e7a2fd857322 ]
The stack_pools[] array has DEPOT_MAX_POOLS. The "pools_num" tracks the
number of pools which are initialized. See depot_init_pool() for more
details.
If pool_index == pools_num_cached, this will read one element beyond what
we want. If not all the pools are initialized, then the pool will be
NULL, triggering a WARN(), and if they are all initialized it will read
one element beyond the end of the array.
Link: https://lkml.kernel.org/r/361ac881-60b7-471f-91e5-5bf8fe8042b2@moroto.mountain
Fixes: b29d31885814 ("lib/stackdepot: store free stack records in a freelist")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/stackdepot.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/stackdepot.c b/lib/stackdepot.c index c043a4186bc5..c1ec2b4b6dab 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -490,7 +490,7 @@ static struct stack_record *depot_fetch_stack(depot_stack_handle_t handle) lockdep_assert_not_held(&pool_lock); - if (pool_index > pools_num_cached) { + if (pool_index >= pools_num_cached) { WARN(1, "pool index %d out of bounds (%d) for stack id %08x\n", pool_index, pools_num_cached, handle); return NULL; |