summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorYu Kuai <yukuai3@huawei.com>2024-02-01 12:25:51 +0300
committerSong Liu <song@kernel.org>2024-02-08 10:44:19 +0300
commit855678ed8534518e2b428bcbcec695de9ba248e8 (patch)
tree97baddcd94310b812f56e45b24003095607bb295 /lib
parent9f3fe29d77ef4e7f7cb5c4c8c59f6dc373e57e78 (diff)
downloadlinux-855678ed8534518e2b428bcbcec695de9ba248e8.tar.xz
md: Fix missing release of 'active_io' for flush
submit_flushes atomic_set(&mddev->flush_pending, 1); rdev_for_each_rcu(rdev, mddev) atomic_inc(&mddev->flush_pending); bi->bi_end_io = md_end_flush submit_bio(bi); /* flush io is done first */ md_end_flush if (atomic_dec_and_test(&mddev->flush_pending)) percpu_ref_put(&mddev->active_io) -> active_io is not released if (atomic_dec_and_test(&mddev->flush_pending)) -> missing release of active_io For consequence, mddev_suspend() will wait for 'active_io' to be zero forever. Fix this problem by releasing 'active_io' in submit_flushes() if 'flush_pending' is decreased to zero. Fixes: fa2bbff7b0b4 ("md: synchronize flush io with array reconfiguration") Cc: stable@vger.kernel.org # v6.1+ Reported-by: Blazej Kucman <blazej.kucman@linux.intel.com> Closes: https://lore.kernel.org/lkml/20240130172524.0000417b@linux.intel.com/ Signed-off-by: Yu Kuai <yukuai3@huawei.com> Signed-off-by: Song Liu <song@kernel.org> Link: https://lore.kernel.org/r/20240201092559.910982-7-yukuai1@huaweicloud.com
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions