diff options
author | Amir Goldstein <amir73il@gmail.com> | 2022-05-11 22:02:13 +0300 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2022-05-18 16:08:09 +0300 |
commit | e730558adffb88a52e562db089e969ee9510184a (patch) | |
tree | 518bd7a2fd19903346d8484493480ad4ae2c7961 /lib | |
parent | 14362a2541797cf9df0e86fb12dcd7950baf566e (diff) | |
download | linux-e730558adffb88a52e562db089e969ee9510184a.tar.xz |
fsnotify: consistent behavior for parent not watching children
The logic for handling events on child in groups that have a mark on
the parent inode, but without FS_EVENT_ON_CHILD flag in the mask is
duplicated in several places and inconsistent.
Move the logic into the preparation of mark type iterator, so that the
parent mark type will be excluded from all mark type iterations in that
case.
This results in several subtle changes of behavior, hopefully all
desired changes of behavior, for example:
- Group A has a mount mark with FS_MODIFY in mask
- Group A has a mark with ignore mask that does not survive FS_MODIFY
and does not watch children on directory D.
- Group B has a mark with FS_MODIFY in mask that does watch children
on directory D.
- FS_MODIFY event on file D/foo should not clear the ignore mask of
group A, but before this change it does
And if group A ignore mask was set to survive FS_MODIFY:
- FS_MODIFY event on file D/foo should be reported to group A on account
of the mount mark, but before this change it is wrongly ignored
Fixes: 2f02fd3fa13e ("fanotify: fix ignore mask logic for events on child and on dir")
Reported-by: Jan Kara <jack@suse.com>
Link: https://lore.kernel.org/linux-fsdevel/20220314113337.j7slrb5srxukztje@quack3.lan/
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220511190213.831646-3-amir73il@gmail.com
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions