diff options
| author | Dominique Martinet <dominique.martinet@cea.fr> | 2018-09-07 19:18:43 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-11-21 11:27:39 +0300 |
| commit | 55e464966baf3e57374540f058ab68d6dce15f32 (patch) | |
| tree | 867cf648bb7374c8f2fe0fa8b0be3955bbeee7fe /net/9p/protocol.c | |
| parent | 155bd1c4bfc949a2b3250d7136a361e99d38e635 (diff) | |
| download | linux-55e464966baf3e57374540f058ab68d6dce15f32.tar.xz | |
9p locks: fix glock.client_id leak in do_lock
[ Upstream commit b4dc44b3cac9e8327e0655f530ed0c46f2e6214c ]
the 9p client code overwrites our glock.client_id pointing to a static
buffer by an allocated string holding the network provided value which
we do not care about; free and reset the value as appropriate.
This is almost identical to the leak in v9fs_file_getlock() fixed by
Al Viro in commit ce85dd58ad5a6 ("9p: we are leaking glock.client_id
in v9fs_file_getlock()"), which was returned as an error by a coverity
false positive -- while we are here attempt to make the code slightly
more robust to future change of the net/9p/client code and hopefully
more clear to coverity that there is no problem.
Link: http://lkml.kernel.org/r/1536339057-21974-5-git-send-email-asmadeus@codewreck.org
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/9p/protocol.c')
0 files changed, 0 insertions, 0 deletions