summaryrefslogtreecommitdiff
path: root/net/9p
diff options
context:
space:
mode:
authorWang Hai <wanghai38@huawei.com>2022-11-24 11:10:05 +0300
committerDavid S. Miller <davem@davemloft.net>2022-11-28 14:09:13 +0300
commitdcc14cfd7debe11b825cb077e75d91d2575b4cb8 (patch)
treea9fca1243eec8016a7590511b47b083f3491dd5c /net/9p
parentb8f79dccd38edf7db4911c353d9cd792ab13a327 (diff)
downloadlinux-dcc14cfd7debe11b825cb077e75d91d2575b4cb8.tar.xz
net/9p: Fix a potential socket leak in p9_socket_open
Both p9_fd_create_tcp() and p9_fd_create_unix() will call p9_socket_open(). If the creation of p9_trans_fd fails, p9_fd_create_tcp() and p9_fd_create_unix() will return an error directly instead of releasing the cscoket, which will result in a socket leak. This patch adds sock_release() to fix the leak issue. Fixes: 6b18662e239a ("9p connect fixes") Signed-off-by: Wang Hai <wanghai38@huawei.com> ACKed-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/9p')
-rw-r--r--net/9p/trans_fd.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
index 56a186768750..f834726d21ea 100644
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -860,8 +860,10 @@ static int p9_socket_open(struct p9_client *client, struct socket *csocket)
struct file *file;
p = kzalloc(sizeof(struct p9_trans_fd), GFP_KERNEL);
- if (!p)
+ if (!p) {
+ sock_release(csocket);
return -ENOMEM;
+ }
csocket->sk->sk_allocation = GFP_NOIO;
file = sock_alloc_file(csocket, 0, NULL);