diff options
author | Jonathan Cooper <jonathan.s.cooper@amd.com> | 2022-10-13 12:55:53 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2022-10-15 13:06:44 +0300 |
commit | a8aed7b35becfd21f22a77c7014029ea837b018f (patch) | |
tree | a03d9decd48fbb72e0875a697226eb5f78dcd501 /net/atm/lec.h | |
parent | 0c93411795513a0e8dfcb5bcc7bab756b98bfc73 (diff) | |
download | linux-a8aed7b35becfd21f22a77c7014029ea837b018f.tar.xz |
sfc: Change VF mac via PF as first preference if available.
Changing a VF's mac address through the VF (rather than via the PF)
fails with EPERM because the latter part of efx_ef10_set_mac_address
attempts to change the vport mac address list as the VF.
Even with this fixed it still fails with EBUSY because the vadaptor
is still assigned on the VF - the vadaptor reassignment must be within
a section where the VF has torn down its state.
A major reason this has broken is because we have two functions that
ostensibly do the same thing - have a PF and VF cooperate to change a
VF mac address. Rather than do this, if we are changing the mac of a VF
that has a link to the PF in the same VM then simply call
sriov_set_vf_mac instead, which is a proven working function that does
that.
If there is no PF available, or that fails non-fatally, then attempt to
change the VF's mac address as we would a PF, without updating the PF's
data.
Test case:
Create a VF:
echo 1 > /sys/class/net/<if>/device/sriov_numvfs
Set the mac address of the VF directly:
ip link set <vf> addr 00:11:22:33:44:55
Set the MAC address of the VF via the PF:
ip link set <pf> vf 0 mac 00:11:22:33:44:66
Without this patch the last command will fail with ENOENT.
Signed-off-by: Jonathan Cooper <jonathan.s.cooper@amd.com>
Reported-by: Íñigo Huguet <ihuguet@redhat.com>
Fixes: 910c8789a777 ("set the MAC address using MC_CMD_VADAPTOR_SET_MAC")
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/atm/lec.h')
0 files changed, 0 insertions, 0 deletions