diff options
author | Wei Wang <weiwan@google.com> | 2019-05-16 23:30:54 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-05-17 00:30:53 +0300 |
commit | 510e2ceda031eed97a7a0f9aad65d271a58b460d (patch) | |
tree | bd45f013d94d901034ec055e63cf83fd8427e89f /net/caif/cfvidl.c | |
parent | 9a6c8bf91b6025b1bb95d4fb454a16019ad22fc4 (diff) | |
download | linux-510e2ceda031eed97a7a0f9aad65d271a58b460d.tar.xz |
ipv6: fix src addr routing with the exception table
When inserting route cache into the exception table, the key is
generated with both src_addr and dest_addr with src addr routing.
However, current logic always assumes the src_addr used to generate the
key is a /128 host address. This is not true in the following scenarios:
1. When the route is a gateway route or does not have next hop.
(rt6_is_gw_or_nonexthop() == false)
2. When calling ip6_rt_cache_alloc(), saddr is passed in as NULL.
This means, when looking for a route cache in the exception table, we
have to do the lookup twice: first time with the passed in /128 host
address, second time with the src_addr stored in fib6_info.
This solves the pmtu discovery issue reported by Mikael Magnusson where
a route cache with a lower mtu info is created for a gateway route with
src addr. However, the lookup code is not able to find this route cache.
Fixes: 2b760fcf5cfb ("ipv6: hook up exception table to store dst cache")
Reported-by: Mikael Magnusson <mikael.kernel@lists.m7n.se>
Bisected-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Wei Wang <weiwan@google.com>
Cc: Martin Lau <kafai@fb.com>
Cc: Eric Dumazet <edumazet@google.com>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/caif/cfvidl.c')
0 files changed, 0 insertions, 0 deletions