summaryrefslogtreecommitdiff
path: root/net/decnet
diff options
context:
space:
mode:
authorVadim Fedorenko <vfedorenko@novek.ru>2021-01-26 03:02:14 +0300
committerJakub Kicinski <kuba@kernel.org>2021-01-28 04:33:46 +0300
commit3f96d644976825986a93b7b9fe6a9900a80f2e11 (patch)
tree893747792bcf57b264ad72d6004ec30f7a6e492f /net/decnet
parent20776b465c0c249f5e5b5b4fe077cd24ef1cda86 (diff)
downloadlinux-3f96d644976825986a93b7b9fe6a9900a80f2e11.tar.xz
net: decnet: fix netdev refcount leaking on error path
On building the route there is an assumption that the destination could be local. In this case loopback_dev is used to get the address. If the address is still cannot be retrieved dn_route_output_slow returns EADDRNOTAVAIL with loopback_dev reference taken. Cannot find hash for the fixes tag because this code was introduced long time ago. I don't think that this bug has ever fired but the patch is done just to have a consistent code base. Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru> Link: https://lore.kernel.org/r/1611619334-20955-1-git-send-email-vfedorenko@novek.ru Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/decnet')
-rw-r--r--net/decnet/dn_route.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index 4cac31d22a50..2193ae529e75 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -1035,7 +1035,7 @@ source_ok:
fld.saddr = dnet_select_source(dev_out, 0,
RT_SCOPE_HOST);
if (!fld.daddr)
- goto out;
+ goto done;
}
fld.flowidn_oif = LOOPBACK_IFINDEX;
res.type = RTN_LOCAL;