summaryrefslogtreecommitdiff
path: root/net/dsa
diff options
context:
space:
mode:
authorAaron Conole <aconole@redhat.com>2022-03-18 15:43:19 +0300
committerJakub Kicinski <kuba@kernel.org>2022-03-22 08:29:10 +0300
commit60b44ca6bd7518dd38fa2719bc9240378b6172c3 (patch)
tree88c003c460c70e52093cd3e8a631ae0ad620a5e8 /net/dsa
parented0c99dc0f499ff8b6e75b5ae6092ab42be1ad39 (diff)
downloadlinux-60b44ca6bd7518dd38fa2719bc9240378b6172c3.tar.xz
openvswitch: always update flow key after nat
During NAT, a tuple collision may occur. When this happens, openvswitch will make a second pass through NAT which will perform additional packet modification. This will update the skb data, but not the flow key that OVS uses. This means that future flow lookups, and packet matches will have incorrect data. This has been supported since 5d50aa83e2c8 ("openvswitch: support asymmetric conntrack"). That commit failed to properly update the sw_flow_key attributes, since it only called the ovs_ct_nat_update_key once, rather than each time ovs_ct_nat_execute was called. As these two operations are linked, the ovs_ct_nat_execute() function should always make sure that the sw_flow_key is updated after a successful call through NAT infrastructure. Fixes: 5d50aa83e2c8 ("openvswitch: support asymmetric conntrack") Cc: Dumitru Ceara <dceara@redhat.com> Cc: Numan Siddique <nusiddiq@redhat.com> Signed-off-by: Aaron Conole <aconole@redhat.com> Acked-by: Eelco Chaudron <echaudro@redhat.com> Link: https://lore.kernel.org/r/20220318124319.3056455-1-aconole@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/dsa')
0 files changed, 0 insertions, 0 deletions