diff options
| author | Eric Dumazet <edumazet@google.com> | 2022-06-18 06:47:05 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-06-19 12:00:02 +0300 |
| commit | 0daf07e527095e64ee8927ce297ab626643e9f51 (patch) | |
| tree | c74d50c59f37ae3e636d6976734762811e118c27 /net/ipv4/af_inet.c | |
| parent | ba44f8182ec299c5d1c8a72fc0fde4ec127b5a6d (diff) | |
| download | linux-0daf07e527095e64ee8927ce297ab626643e9f51.tar.xz | |
raw: convert raw sockets to RCU
Using rwlock in networking code is extremely risky.
writers can starve if enough readers are constantly
grabing the rwlock.
I thought rwlock were at fault and sent this patch:
https://lkml.org/lkml/2022/6/17/272
But Peter and Linus essentially told me rwlock had to be unfair.
We need to get rid of rwlock in networking code.
Without this fix, following script triggers soft lockups:
for i in {1..48}
do
ping -f -n -q 127.0.0.1 &
sleep 0.1
done
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/af_inet.c')
| -rw-r--r-- | net/ipv4/af_inet.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index 30e0e8992085..da81f56fdd1c 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -1929,6 +1929,8 @@ static int __init inet_init(void) sock_skb_cb_check_size(sizeof(struct inet_skb_parm)); + raw_hashinfo_init(&raw_v4_hashinfo); + rc = proto_register(&tcp_prot, 1); if (rc) goto out; |