summaryrefslogtreecommitdiff
path: root/net/ipv6/udplite.c
diff options
context:
space:
mode:
authorKuniyuki Iwashima <kuniyu@amazon.com>2022-10-06 21:53:46 +0300
committerJakub Kicinski <kuba@kernel.org>2022-10-13 03:50:37 +0300
commit21985f43376cee092702d6cb963ff97a9d2ede68 (patch)
tree0084a093718e00e822b53495b5f506a2aee4ea15 /net/ipv6/udplite.c
parent3c52c6bb831f6335c176a0fc7214e26f43adbd11 (diff)
downloadlinux-21985f43376cee092702d6cb963ff97a9d2ede68.tar.xz
udp: Call inet6_destroy_sock() in setsockopt(IPV6_ADDRFORM).
Commit 4b340ae20d0e ("IPv6: Complete IPV6_DONTFRAG support") forgot to add a change to free inet6_sk(sk)->rxpmtu while converting an IPv6 socket into IPv4 with IPV6_ADDRFORM. After conversion, sk_prot is changed to udp_prot and ->destroy() never cleans it up, resulting in a memory leak. This is due to the discrepancy between inet6_destroy_sock() and IPV6_ADDRFORM, so let's call inet6_destroy_sock() from IPV6_ADDRFORM to remove the difference. However, this is not enough for now because rxpmtu can be changed without lock_sock() after commit 03485f2adcde ("udpv6: Add lockless sendmsg() support"). We will fix this case in the following patch. Note we will rename inet6_destroy_sock() to inet6_cleanup_sock() and remove unnecessary inet6_destroy_sock() calls in sk_prot->destroy() in the future. Fixes: 4b340ae20d0e ("IPv6: Complete IPV6_DONTFRAG support") Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ipv6/udplite.c')
0 files changed, 0 insertions, 0 deletions