diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2022-01-10 22:48:17 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-01-11 08:09:43 +0300 |
| commit | 51edb2ff1c6fc27d3fa73f0773a31597ecd8e230 (patch) | |
| tree | dbba7f1c889cf6ca87766bdb671085caedb0cacc /net/netfilter/nft_limit.c | |
| parent | fe8152b38d3a994c4c6fdbc0cd6551d569a5715a (diff) | |
| download | linux-51edb2ff1c6fc27d3fa73f0773a31597ecd8e230.tar.xz | |
netfilter: nf_tables: typo NULL check in _clone() function
This should check for NULL in case memory allocation fails.
Reported-by: Julian Wiedmann <jwiedmann.dev@gmail.com>
Fixes: 3b9e2ea6c11b ("netfilter: nft_limit: move stateful fields out of expression data")
Fixes: 37f319f37d90 ("netfilter: nft_connlimit: move stateful fields out of expression data")
Fixes: 33a24de37e81 ("netfilter: nft_last: move stateful fields out of expression data")
Fixes: ed0a0c60f0e5 ("netfilter: nft_quota: move stateful fields out of expression data")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Link: https://lore.kernel.org/r/20220110194817.53481-1-pablo@netfilter.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/netfilter/nft_limit.c')
| -rw-r--r-- | net/netfilter/nft_limit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nft_limit.c b/net/netfilter/nft_limit.c index f04be5be73a0..c4f308460dd1 100644 --- a/net/netfilter/nft_limit.c +++ b/net/netfilter/nft_limit.c @@ -145,7 +145,7 @@ static int nft_limit_clone(struct nft_limit_priv *priv_dst, priv_dst->invert = priv_src->invert; priv_dst->limit = kmalloc(sizeof(*priv_dst->limit), GFP_ATOMIC); - if (priv_dst->limit) + if (!priv_dst->limit) return -ENOMEM; spin_lock_init(&priv_dst->limit->lock); |