diff options
author | Anoob Soman <anoob.soman@citrix.com> | 2016-10-05 17:12:54 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-04-18 08:55:46 +0300 |
commit | 1cfbcf93abf94142f750f533140bd2f68b83d6c6 (patch) | |
tree | ccc7b0bb328cfbbfae8f5b91dcae9491f3d76c80 /net/packet | |
parent | bd73f80dccf3377f985e564f885778f9c2b29d19 (diff) | |
download | linux-1cfbcf93abf94142f750f533140bd2f68b83d6c6.tar.xz |
packet: call fanout_release, while UNREGISTERING a netdev
[ Upstream commit 6664498280cf17a59c3e7cf1a931444c02633ed1 ]
If a socket has FANOUT sockopt set, a new proto_hook is registered
as part of fanout_add(). When processing a NETDEV_UNREGISTER event in
af_packet, __fanout_unlink is called for all sockets, but prot_hook which was
registered as part of fanout_add is not removed. Call fanout_release, on a
NETDEV_UNREGISTER, which removes prot_hook and removes fanout from the
fanout_list.
This fixes BUG_ON(!list_empty(&dev->ptype_specific)) in netdev_run_todo()
Signed-off-by: Anoob Soman <anoob.soman@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/packet')
-rw-r--r-- | net/packet/af_packet.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index abffc1519e4d..78efc5553abb 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -3552,6 +3552,7 @@ static int packet_notifier(struct notifier_block *this, } if (msg == NETDEV_UNREGISTER) { packet_cached_dev_reset(po); + fanout_release(sk); po->ifindex = -1; if (po->prot_hook.dev) dev_put(po->prot_hook.dev); |