diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2021-05-19 18:58:52 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-07-14 17:56:16 +0300 |
| commit | 27e9e0c4681633c1108dc2c0ad982606cb442724 (patch) | |
| tree | 19572cd0d52ca4109c5c159241354fe1ab6c3972 /net/qrtr | |
| parent | 40b701707ebfc7f362fdbf3fdf7c2803e86fa552 (diff) | |
| download | linux-27e9e0c4681633c1108dc2c0ad982606cb442724.tar.xz | |
net: qrtr: ns: Fix error return code in qrtr_ns_init()
[ Upstream commit a49e72b3bda73d36664a084e47da9727a31b8095 ]
Fix to return a negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: c6e08d6251f3 ("net: qrtr: Allocate workqueue before kernel_bind")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net/qrtr')
| -rw-r--r-- | net/qrtr/ns.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c index b8559c882431..e760d4a38faf 100644 --- a/net/qrtr/ns.c +++ b/net/qrtr/ns.c @@ -783,8 +783,10 @@ void qrtr_ns_init(void) } qrtr_ns.workqueue = alloc_workqueue("qrtr_ns_handler", WQ_UNBOUND, 1); - if (!qrtr_ns.workqueue) + if (!qrtr_ns.workqueue) { + ret = -ENOMEM; goto err_sock; + } qrtr_ns.sock->sk->sk_data_ready = qrtr_ns_data_ready; |