summaryrefslogtreecommitdiff
path: root/net/sched
diff options
context:
space:
mode:
authorIdo Schimmel <idosch@nvidia.com>2022-04-07 10:35:33 +0300
committerDavid S. Miller <davem@davemloft.net>2022-04-08 15:45:43 +0300
commitfd23e0e250c6a7a7fd8a2ec9ab4253299471c163 (patch)
tree9bd6dea5afa846d60e7c3ab00e6599ef7d7cccdd /net/sched
parent0cba5c34b8f4b4b81e5102992c8a9e189ec27768 (diff)
downloadlinux-fd23e0e250c6a7a7fd8a2ec9ab4253299471c163.tar.xz
net/sched: flower: Avoid overwriting error messages
The various error paths of tc_setup_offload_action() now report specific error messages. Remove the generic messages to avoid overwriting the more specific ones. Before: # tc filter add dev dummy0 ingress pref 1 proto ip flower skip_sw dst_ip 198.51.100.1 action police rate 100Mbit burst 10000 Error: cls_flower: Failed to setup flow action. We have an error talking to the kernel After: # tc filter add dev dummy0 ingress pref 1 proto ip flower skip_sw dst_ip 198.51.100.1 action police rate 100Mbit burst 10000 Error: act_police: Offload not supported when conform/exceed action is "reclassify". We have an error talking to the kernel Signed-off-by: Ido Schimmel <idosch@nvidia.com> Reviewed-by: Petr Machata <petrm@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched')
-rw-r--r--net/sched/cls_flower.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
index acf827b0e30a..87e030dfc328 100644
--- a/net/sched/cls_flower.c
+++ b/net/sched/cls_flower.c
@@ -468,8 +468,6 @@ static int fl_hw_replace_filter(struct tcf_proto *tp,
cls_flower.common.extack);
if (err) {
kfree(cls_flower.rule);
- NL_SET_ERR_MSG_MOD(cls_flower.common.extack,
- "Failed to setup flow action");
return skip_sw ? err : 0;
}
@@ -2358,8 +2356,6 @@ static int fl_reoffload(struct tcf_proto *tp, bool add, flow_setup_cb_t *cb,
cls_flower.common.extack);
if (err) {
kfree(cls_flower.rule);
- NL_SET_ERR_MSG_MOD(cls_flower.common.extack,
- "Failed to setup flow action");
if (tc_skip_sw(f->flags)) {
__fl_put(f);
return err;