summaryrefslogtreecommitdiff
path: root/net/sunrpc/svc.c
diff options
context:
space:
mode:
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>2022-05-10 17:38:33 +0300
committerChuck Lever <chuck.lever@oracle.com>2022-05-19 19:25:40 +0300
commit586095d339b1b46f4283863e6e8e15de662a3f93 (patch)
tree75c581d0e3e6e0141eddebd654f1ca3501c62195 /net/sunrpc/svc.c
parente9488d5ae13c0a72223c507e2508dc2ac66cad4f (diff)
downloadlinux-586095d339b1b46f4283863e6e8e15de662a3f93.tar.xz
SUNRPC: Don't disable preemption while calling svc_pool_for_cpu().
svc_xprt_enqueue() disables preemption via get_cpu() and then asks for a pool of a specific CPU (current) via svc_pool_for_cpu(). While preemption is disabled, svc_xprt_enqueue() acquires svc_pool::sp_lock with bottom-halfs disabled, which can sleep on PREEMPT_RT. Disabling preemption is not required here. The pool is protected with a lock so the following list access is safe even cross-CPU. The following iteration through svc_pool::sp_all_threads is under RCU-readlock and remaining operations within the loop are atomic and do not rely on disabled-preemption. Use raw_smp_processor_id() as the argument for the requested CPU in svc_pool_for_cpu(). Reported-by: Mike Galbraith <umgwanakikbuti@gmail.com> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'net/sunrpc/svc.c')
0 files changed, 0 insertions, 0 deletions