diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2022-02-16 20:31:09 +0300 |
|---|---|---|
| committer | Chuck Lever <chuck.lever@oracle.com> | 2022-02-28 18:26:40 +0300 |
| commit | f49169c97fceb21ad6a0aaf671c50b0f520f15a5 (patch) | |
| tree | abab469433578ffa4da9aedf787258f504eb62ad /net/sunrpc/svc.c | |
| parent | c7d7ec8f043e53ad16e30f5ebb8b9df415ec0f2b (diff) | |
| download | linux-f49169c97fceb21ad6a0aaf671c50b0f520f15a5.tar.xz | |
NFSD: Remove svc_serv_ops::svo_module
struct svc_serv_ops is about to be removed.
Neil Brown says:
> I suspect svo_module can go as well - I don't think the thread is
> ever the thing that primarily keeps a module active.
A random sample of kthread_create() callers shows sunrpc is the only
one that manages module reference count in this way.
Suggested-by: Neil Brown <neilb@suse.de>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'net/sunrpc/svc.c')
| -rw-r--r-- | net/sunrpc/svc.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c index 08d684746452..a90d555aa163 100644 --- a/net/sunrpc/svc.c +++ b/net/sunrpc/svc.c @@ -736,11 +736,9 @@ svc_start_kthreads(struct svc_serv *serv, struct svc_pool *pool, int nrservs) if (IS_ERR(rqstp)) return PTR_ERR(rqstp); - __module_get(serv->sv_ops->svo_module); task = kthread_create_on_node(serv->sv_ops->svo_function, rqstp, node, "%s", serv->sv_name); if (IS_ERR(task)) { - module_put(serv->sv_ops->svo_module); svc_exit_thread(rqstp); return PTR_ERR(task); } |