summaryrefslogtreecommitdiff
path: root/net/unix/af_unix.c
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2016-01-25 00:53:50 +0300
committerDavid S. Miller <davem@davemloft.net>2016-01-25 09:04:49 +0300
commitfa0dc04df259ba2df3ce1920e9690c7842f8fa4b (patch)
treede00379849c3284fd3cd1cd7359792dd741305ef /net/unix/af_unix.c
parent4877be9019baaf1432f9117bff4873e4ad518d91 (diff)
downloadlinux-fa0dc04df259ba2df3ce1920e9690c7842f8fa4b.tar.xz
af_unix: fix struct pid memory leak
Dmitry reported a struct pid leak detected by a syzkaller program. Bug happens in unix_stream_recvmsg() when we break the loop when a signal is pending, without properly releasing scm. Fixes: b3ca9b02b007 ("net: fix multithreaded signal handling in unix recv routines") Reported-by: Dmitry Vyukov <dvyukov@google.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Rainer Weikusat <rweikusat@mobileactivedefense.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/unix/af_unix.c')
-rw-r--r--net/unix/af_unix.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index c5bf5ef2bf89..49d5093eb055 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -2339,6 +2339,7 @@ again:
if (signal_pending(current)) {
err = sock_intr_errno(timeo);
+ scm_destroy(&scm);
goto out;
}