diff options
| author | NeilBrown <neilb@suse.de> | 2021-02-05 03:36:30 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-02-08 21:15:49 +0300 |
| commit | af8085f3a4712c57d0dd415ad543bac85780375c (patch) | |
| tree | 2dbdc0e116d3ae862ff448bdcb434dc3ef8f0757 /net/vmw_vsock | |
| parent | 225353c070fda18a23785e34e1eec2be508a3a3c (diff) | |
| download | linux-af8085f3a4712c57d0dd415ad543bac85780375c.tar.xz | |
net: fix iteration for sctp transport seq_files
The sctp transport seq_file iterators take a reference to the transport
in the ->start and ->next functions and releases the reference in the
->show function. The preferred handling for such resources is to
release them in the subsequent ->next or ->stop function call.
Since Commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration
code and interface") there is no guarantee that ->show will be called
after ->next, so this function can now leak references.
So move the sctp_transport_put() call to ->next and ->stop.
Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface")
Reported-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/vmw_vsock')
0 files changed, 0 insertions, 0 deletions