diff options
| author | Florian Westphal <fw@strlen.de> | 2023-05-11 23:45:35 +0300 |
|---|---|---|
| committer | Florian Westphal <fw@strlen.de> | 2023-05-18 09:48:54 +0300 |
| commit | d4b7f29eb85c93893bc27388b37709efbc3c9a0e (patch) | |
| tree | e97495a0b3e44403847163bac340eef612ec0f19 /net | |
| parent | a4878eeae39048e6abe85891c714b49dc13fc08c (diff) | |
| download | linux-d4b7f29eb85c93893bc27388b37709efbc3c9a0e.tar.xz | |
netfilter: nf_tables: always increment set element count
At this time, set->nelems counter only increments when the set has
a maximum size.
All set elements decrement the counter unconditionally, this is
confusing.
Increment the counter unconditionally to make this symmetrical.
This would also allow changing the set maximum size after set creation
in a later patch.
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'net')
| -rw-r--r-- | net/netfilter/nf_tables_api.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 59fb8320ab4d..7a61de80a8d1 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -6541,10 +6541,13 @@ static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set, goto err_element_clash; } - if (!(flags & NFT_SET_ELEM_CATCHALL) && set->size && - !atomic_add_unless(&set->nelems, 1, set->size + set->ndeact)) { - err = -ENFILE; - goto err_set_full; + if (!(flags & NFT_SET_ELEM_CATCHALL)) { + unsigned int max = set->size ? set->size + set->ndeact : UINT_MAX; + + if (!atomic_add_unless(&set->nelems, 1, max)) { + err = -ENFILE; + goto err_set_full; + } } nft_trans_elem(trans) = elem; |