diff options
| author | YueHaibing <yuehaibing@huawei.com> | 2019-04-30 14:34:08 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-12-21 12:35:03 +0300 |
| commit | 3a686d60f77c0dfc980ec12bd30f47b8b9184a84 (patch) | |
| tree | 66ed0dc68354869d33030e163ddcac77f4711e82 /net | |
| parent | 7ae3525ee708f867a2d2321c246b285136cdbed8 (diff) | |
| download | linux-3a686d60f77c0dfc980ec12bd30f47b8b9184a84.tar.xz | |
appletalk: Set error code if register_snap_client failed
commit c93ad1337ad06a718890a89cdd85188ff9a5a5cc upstream.
If register_snap_client fails in atalk_init,
error code should be set, otherwise it will
triggers NULL pointer dereference while unloading
module.
Fixes: 9804501fa122 ("appletalk: Fix potential NULL pointer dereference in unregister_snap_client")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/appletalk/ddp.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 9239aa7b7c0d..ace94170f55e 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -1927,6 +1927,7 @@ static int __init atalk_init(void) ddp_dl = register_snap_client(ddp_snap_id, atalk_rcv); if (!ddp_dl) { pr_crit("Unable to register DDP with SNAP.\n"); + rc = -ENOMEM; goto out_sock; } |