summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorDan Aloni <dan.aloni@vastdata.com>2022-07-04 15:56:57 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-08-25 12:37:56 +0300
commit59d2e8fa4127c1417a5b3e0f33e59ae8216df720 (patch)
tree4789dcc00befeddb0c205a087fb06beeebaf35ae /net
parentdf60c534d4c5a681172952dd4b475a5d818b3a86 (diff)
downloadlinux-59d2e8fa4127c1417a5b3e0f33e59ae8216df720.tar.xz
sunrpc: fix expiry of auth creds
commit f1bafa7375c01ff71fb7cb97c06caadfcfe815f3 upstream. Before this commit, with a large enough LRU of expired items (100), the loop skipped all the expired items and was entirely ineffectual in trimming the LRU list. Fixes: 95cd623250ad ('SUNRPC: Clean up the AUTH cache code') Signed-off-by: Dan Aloni <dan.aloni@vastdata.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
-rw-r--r--net/sunrpc/auth.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
index a9f0d17fdb0d..1bae32c48284 100644
--- a/net/sunrpc/auth.c
+++ b/net/sunrpc/auth.c
@@ -445,7 +445,7 @@ rpcauth_prune_expired(struct list_head *free, int nr_to_scan)
* Enforce a 60 second garbage collection moratorium
* Note that the cred_unused list must be time-ordered.
*/
- if (!time_in_range(cred->cr_expire, expired, jiffies))
+ if (time_in_range(cred->cr_expire, expired, jiffies))
continue;
if (!rpcauth_unhash_cred(cred))
continue;