diff options
| author | Ratheesh Kannoth <rkannoth@marvell.com> | 2023-09-08 05:53:09 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-09-10 21:29:15 +0300 |
| commit | 88e69af061f2e061a68751ef9cad47a674527a1b (patch) | |
| tree | fba9d374b5d9bca50ec5f88623f3c7a4aaa04529 /net | |
| parent | 281f65d29d6da1a9b6907fb0b145aaf34f4e4822 (diff) | |
| download | linux-88e69af061f2e061a68751ef9cad47a674527a1b.tar.xz | |
octeontx2-pf: Fix page pool cache index corruption.
The access to page pool `cache' array and the `count' variable
is not locked. Page pool cache access is fine as long as there
is only one consumer per pool.
octeontx2 driver fills in rx buffers from page pool in NAPI context.
If system is stressed and could not allocate buffers, refiiling work
will be delegated to a delayed workqueue. This means that there are
two cosumers to the page pool cache.
Either workqueue or IRQ/NAPI can be run on other CPU. This will lead
to lock less access, hence corruption of cache pool indexes.
To fix this issue, NAPI is rescheduled from workqueue context to refill
rx buffers.
Fixes: b2e3406a38f0 ("octeontx2-pf: Add support for page pool")
Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions