summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-07-04 18:21:12 +0300
committerDavid S. Miller <davem@davemloft.net>2017-07-05 11:08:54 +0300
commit6d3f06a0042ebd59a5e9d4ba6e8a85596901e140 (patch)
treec8e47d37f770820e04fd16adcdc4f7cfa57008bc /net
parentf856e46978b8cfaa62cf13738ebab38684b96222 (diff)
downloadlinux-6d3f06a0042ebd59a5e9d4ba6e8a85596901e140.tar.xz
bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case
There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case. Currently the non-error path where val is greater than zero falls through to the default case that sets the error return to -EINVAL. Add in the missing break. Detected by CoverityScan, CID#1449376 ("Missing break in switch") Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp") Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Lawrence Brakmo <brakmo@fb.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/core/filter.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/core/filter.c b/net/core/filter.c
index 94169572d002..c7f737058d89 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -2867,6 +2867,7 @@ BPF_CALL_5(bpf_setsockopt, struct bpf_sock_ops_kern *, bpf_sock,
tp->snd_cwnd_clamp = val;
tp->snd_ssthresh = val;
}
+ break;
default:
ret = -EINVAL;
}