summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorShannon Nelson <snelson@pensando.io>2020-06-09 06:41:43 +0300
committerDavid S. Miller <davem@davemloft.net>2020-06-09 23:19:27 +0300
commit976ee3b21119dcf5c6d96233d688a1453f29fa83 (patch)
tree5bb4fc79ffbe96eb585f120f6ac659836d167645 /net
parent1a3db27ad9a72d033235b9673653962c02e3486e (diff)
downloadlinux-976ee3b21119dcf5c6d96233d688a1453f29fa83.tar.xz
ionic: wait on queue start until after IFF_UP
The netif_running() test looks at __LINK_STATE_START which gets set before ndo_open() is called, there is a window of time between that and when the queues are actually ready to be run. If ionic_check_link_status() notices that the link is up very soon after netif_running() becomes true, it might try to run the queues before they are ready, causing all manner of potential issues. Since the netdev->flags IFF_UP isn't set until after ndo_open() returns, we can wait for that before we allow ionic_check_link_status() to start the queues. On the way back to close, __LINK_STATE_START is cleared before calling ndo_stop(), and IFF_UP is cleared after. Both of these need to be true in order to safely stop the queues from ionic_check_link_status(). Fixes: 49d3b493673a ("ionic: disable the queues on link down") Signed-off-by: Shannon Nelson <snelson@pensando.io> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions