diff options
author | Russell King (Oracle) <rmk+kernel@armlinux.org.uk> | 2024-02-04 15:13:02 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2024-02-07 20:03:37 +0300 |
commit | 0cb6daf549f99cc978fe4dd531d2426313fc08e4 (patch) | |
tree | e290c83b292a2906f9cb9dc05d5e63636696486b /samples/kfifo | |
parent | 1e8f1477aba53fa900f1c318fe675f8f945a4781 (diff) | |
download | linux-0cb6daf549f99cc978fe4dd531d2426313fc08e4.tar.xz |
net: stmmac: remove eee_enabled/eee_active in stmmac_ethtool_op_get_eee()
stmmac_ethtool_op_get_eee() sets both eee_enabled and eee_active, and
then goes on to call phylink_ethtool_get_eee().
phylink_ethtool_get_eee() will return -EOPNOTSUPP if there is no PHY
present, otherwise calling phy_ethtool_get_eee() which in turn will call
genphy_c45_ethtool_get_eee().
genphy_c45_ethtool_get_eee() will overwrite eee_enabled and eee_active
with its own interpretation from the PHYs settings and negotiation
result.
Thus, when there is no PHY, stmmac_ethtool_op_get_eee() will fail with
-EOPNOTSUPP, meaning eee_enabled and eee_active will not be returned to
userspace. When there is a PHY, eee_enabled and eee_active will be
overwritten by phylib, making the setting of these members in
stmmac_ethtool_op_get_eee() entirely unnecessary.
Remove this code, thus simplifying stmmac_ethtool_op_get_eee().
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Link: https://lore.kernel.org/r/E1rWbMs-002cCV-EE@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'samples/kfifo')
0 files changed, 0 insertions, 0 deletions