diff options
author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-07-09 09:13:00 +0300 |
---|---|---|
committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-07-11 17:34:52 +0300 |
commit | d4a74bbfee03acf7bbddc77b9c9236462c744fc7 (patch) | |
tree | 9303e6c70eb8616581ce0f8ca9d88268b71dd9b3 /scripts/coccinelle | |
parent | 3a475b2166fd6aa5ac76e8c605dffdf7a2a457ee (diff) | |
download | linux-d4a74bbfee03acf7bbddc77b9c9236462c744fc7.tar.xz |
kbuild: use -- separater intead of $(filter-out ...) for cc-cross-prefix
arch/mips/Makefile passes prefixes that start with '-' to cc-cross-prefix
when $(tool-archpref) evaluates to the empty string.
They are filtered-out before the $(shell ...) invocation. Otherwise,
'command -v' would be confused.
$ command -v -linux-gcc
bash: command: -l: invalid option
command: usage: command [-pVv] command [arg ...]
Since commit 913ab9780fc0 ("kbuild: use more portable 'command -v' for
cc-cross-prefix"), cc-cross-prefix throws away the stderr output, so
the console is not polluted in any way.
This is not a big deal in practice, but I see a slightly better taste
in adding '--' to teach it that '-linux-gcc' is an argument instead of
a command option.
This will cause extra forking of subshell, but it will not be noticeable
performance regression.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Diffstat (limited to 'scripts/coccinelle')
0 files changed, 0 insertions, 0 deletions