diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2020-08-20 18:16:46 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-08-26 12:49:16 +0300 |
| commit | f09a790a6e463b1bdd3d76f77111a11637d65a3e (patch) | |
| tree | b1b5a842803d0669d92800425bb3952a732caf5f /scripts/file-size.sh | |
| parent | 19881ebab34ff8e0f75006df385a87d8c9e84a79 (diff) | |
| download | linux-f09a790a6e463b1bdd3d76f77111a11637d65a3e.tar.xz | |
kconfig: qconf: remove qInfo() to get back Qt4 support
[ Upstream commit 53efe2e76ca2bfad7f35e0b5330e2ccd44a643e3 ]
qconf is supposed to work with Qt4 and Qt5, but since commit
c4f7398bee9c ("kconfig: qconf: make debug links work again"),
building with Qt4 fails as follows:
HOSTCXX scripts/kconfig/qconf.o
scripts/kconfig/qconf.cc: In member function ‘void ConfigInfoView::clicked(const QUrl&)’:
scripts/kconfig/qconf.cc:1241:3: error: ‘qInfo’ was not declared in this scope; did you mean ‘setInfo’?
1241 | qInfo() << "Clicked link is empty";
| ^~~~~
| setInfo
scripts/kconfig/qconf.cc:1254:3: error: ‘qInfo’ was not declared in this scope; did you mean ‘setInfo’?
1254 | qInfo() << "Clicked symbol is invalid:" << data;
| ^~~~~
| setInfo
make[1]: *** [scripts/Makefile.host:129: scripts/kconfig/qconf.o] Error 1
make: *** [Makefile:606: xconfig] Error 2
qInfo() does not exist in Qt4. In my understanding, these call-sites
should be unreachable. Perhaps, qWarning(), assertion, or something
is better, but qInfo() is not the right one to use here, I think.
Fixes: c4f7398bee9c ("kconfig: qconf: make debug links work again")
Reported-by: Ronald Warsow <rwarsow@gmx.de>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'scripts/file-size.sh')
0 files changed, 0 insertions, 0 deletions