diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2023-06-11 18:50:50 +0300 |
|---|---|---|
| committer | Masahiro Yamada <masahiroy@kernel.org> | 2023-06-14 22:47:05 +0300 |
| commit | 92e2921eeafdfca9acd9b83f07d2b7ca099bac24 (patch) | |
| tree | 3f4381bed69db36cc1c334d33f8c003ba42c65a3 /scripts | |
| parent | 1c975da56a6f89a3e610cc86d92f65de3da7bd61 (diff) | |
| download | linux-92e2921eeafdfca9acd9b83f07d2b7ca099bac24.tar.xz | |
ARC: define ASM_NL and __ALIGN(_STR) outside #ifdef __ASSEMBLY__ guard
ASM_NL is useful not only in *.S files but also in .c files for using
inline assembler in C code.
On ARC, however, ASM_NL is evaluated inconsistently. It is expanded to
a backquote (`) in *.S files, but a semicolon (;) in *.c files because
arch/arc/include/asm/linkage.h defines it inside #ifdef __ASSEMBLY__,
so the definition for C code falls back to the default value defined in
include/linux/linkage.h.
If ASM_NL is used in inline assembler in .c files, it will result in
wrong assembly code because a semicolon is not an instruction separator,
but the start of a comment for ARC.
Move ASM_NL (also __ALIGN and __ALIGN_STR) out of the #ifdef.
Fixes: 9df62f054406 ("arch: use ASM_NL instead of ';' for assembler new line character in the macro")
Fixes: 8d92e992a785 ("ARC: define __ALIGN_STR and __ALIGN symbols for ARC")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions