diff options
author | Richard Guy Briggs <rgb@redhat.com> | 2017-10-12 03:57:14 +0300 |
---|---|---|
committer | James Morris <james.l.morris@oracle.com> | 2017-10-20 07:22:46 +0300 |
commit | dbbbe1105ea6aa0c49d78a4ea0d924e0c02307eb (patch) | |
tree | ba8713777af7834790c7589e508baee56da4b47a /security/tomoyo | |
parent | 588fb2c7e294753d3090a1dc2e7c34e7e3ce5aff (diff) | |
download | linux-dbbbe1105ea6aa0c49d78a4ea0d924e0c02307eb.tar.xz |
capabilities: audit log other surprising conditions
The existing condition tested for process effective capabilities set by
file attributes but intended to ignore the change if the result was
unsurprisingly an effective full set in the case root is special with a
setuid root executable file and we are root.
Stated again:
- When you execute a setuid root application, it is no surprise and
expected that it got all capabilities, so we do not want capabilities
recorded.
if (pE_grew && !(pE_fullset && (eff_root || real_root) && root_priveleged) )
Now make sure we cover other cases:
- If something prevented a setuid root app getting all capabilities and
it wound up with one capability only, then it is a surprise and should
be logged. When it is a setuid root file, we only want capabilities
when the process does not get full capabilities..
root_priveleged && setuid_root && !pE_fullset
- Similarly if a non-setuid program does pick up capabilities due to
file system based capabilities, then we want to know what capabilities
were picked up. When it has file system based capabilities we want
the capabilities.
!is_setuid && (has_fcap && pP_gained)
- If it is a non-setuid file and it gets ambient capabilities, we want
the capabilities.
!is_setuid && pA_gained
- These last two are combined into one due to the common first parameter.
Related: https://github.com/linux-audit/audit-kernel/issues/16
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Reviewed-by: Serge Hallyn <serge@hallyn.com>
Acked-by: James Morris <james.l.morris@oracle.com>
Acked-by: Kees Cook <keescook@chromium.org>
Acked-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
Diffstat (limited to 'security/tomoyo')
0 files changed, 0 insertions, 0 deletions