summaryrefslogtreecommitdiff
path: root/security
diff options
context:
space:
mode:
authorMarc Zyngier <maz@kernel.org>2021-04-21 19:43:16 +0300
committerCatalin Marinas <catalin.marinas@arm.com>2021-04-23 20:00:51 +0300
commit1ecd5b129252249b9bc03d7645a7bda512747277 (patch)
treed15669cab1391728552e99177ee34a9fa2bff021 /security
parent0bca3ec846d7a9ea5bddc3b5ab55f6968e690a84 (diff)
downloadlinux-1ecd5b129252249b9bc03d7645a7bda512747277.tar.xz
ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure
When failing the driver probe because of invalid firmware properties, the GTDT driver unmaps the interrupt that it mapped earlier. However, it never checks whether the mapping of the interrupt actially succeeded. Even more, should the firmware report an illegal interrupt number that overlaps with the GIC SGI range, this can result in an IPI being unmapped, and subsequent fireworks (as reported by Dann Frazier). Rework the driver to have a slightly saner behaviour and actually check whether the interrupt has been mapped before unmapping things. Reported-by: dann frazier <dann.frazier@canonical.com> Fixes: ca9ae5ec4ef0 ("acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver") Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/YH87dtTfwYgavusz@xps13.dannf Cc: <stable@vger.kernel.org> Cc: Fu Wei <wefu@redhat.com> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> Tested-by: dann frazier <dann.frazier@canonical.com> Tested-by: Hanjun Guo <guohanjun@huawei.com> Reviewed-by: Hanjun Guo <guohanjun@huawei.com> Reviewed-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Link: https://lore.kernel.org/r/20210421164317.1718831-2-maz@kernel.org Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions