diff options
author | Yufen Yu <yuyufen@huawei.com> | 2021-05-24 12:38:11 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-07-20 17:05:40 +0300 |
commit | 75452cc776683bda53380ade8a2c42371e136ed0 (patch) | |
tree | 520455e848f8833a6b548ac900cf9f2992b16934 /sound/ac97 | |
parent | 664695a754684c5d1dff23e7d1ea650a9dd70801 (diff) | |
download | linux-75452cc776683bda53380ade8a2c42371e136ed0.tar.xz |
ALSA: ac97: fix PM reference leak in ac97_bus_remove()
[ Upstream commit a38e93302ee25b2ca6f4ee76c6c974cf3637985e ]
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yufen Yu <yuyufen@huawei.com>
Link: https://lore.kernel.org/r/20210524093811.612302-1-yuyufen@huawei.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'sound/ac97')
-rw-r--r-- | sound/ac97/bus.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/ac97/bus.c b/sound/ac97/bus.c index 7985dd8198b6..99e1728b52ae 100644 --- a/sound/ac97/bus.c +++ b/sound/ac97/bus.c @@ -520,7 +520,7 @@ static int ac97_bus_remove(struct device *dev) struct ac97_codec_driver *adrv = to_ac97_driver(dev->driver); int ret; - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret < 0) return ret; |