summaryrefslogtreecommitdiff
path: root/sound/core/pcm_lib.c
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2022-03-22 20:07:17 +0300
committerTakashi Iwai <tiwai@suse.de>2022-03-22 22:56:07 +0300
commit92ee3c60ec9fe64404dc035e7c41277d74aa26cb (patch)
tree495dbd456ef721512b0113483cc62e34879e6d6c /sound/core/pcm_lib.c
parent646b907e1559f006c79a752ee3eebe220ceb983d (diff)
downloadlinux-92ee3c60ec9fe64404dc035e7c41277d74aa26cb.tar.xz
ALSA: pcm: Fix races among concurrent hw_params and hw_free calls
Currently we have neither proper check nor protection against the concurrent calls of PCM hw_params and hw_free ioctls, which may result in a UAF. Since the existing PCM stream lock can't be used for protecting the whole ioctl operations, we need a new mutex to protect those racy calls. This patch introduced a new mutex, runtime->buffer_mutex, and applies it to both hw_params and hw_free ioctl code paths. Along with it, the both functions are slightly modified (the mmap_count check is moved into the state-check block) for code simplicity. Reported-by: Hu Jiahui <kirin.say@gmail.com> Cc: <stable@vger.kernel.org> Reviewed-by: Jaroslav Kysela <perex@perex.cz> Link: https://lore.kernel.org/r/20220322170720.3529-2-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core/pcm_lib.c')
0 files changed, 0 insertions, 0 deletions