summaryrefslogtreecommitdiff
path: root/sound/pci/echoaudio
diff options
context:
space:
mode:
authorPan Bian <bianpan2016@163.com>2016-11-29 02:33:07 +0300
committerTakashi Iwai <tiwai@suse.de>2016-11-29 21:59:57 +0300
commite59d8bb574f6d8097e7e14981440dc37425fddc6 (patch)
treedf64e293f927cd8bb16d7280cf8e1b8071e6b614 /sound/pci/echoaudio
parentc6790c8e770c6a7a5414e42438705ec92b03a790 (diff)
downloadlinux-e59d8bb574f6d8097e7e14981440dc37425fddc6.tar.xz
ALSA: echoaudio: Fix improper return value in function load_asic
When the second call to load_asic_generic() fails in function load_asic(), "false" is returned. The real value of "false" is 0, which indicates success in the context. As a result, the execution status and the return value may be inconsistent. This patch fixes the bug. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188761 Signed-off-by: Pan Bian <bianpan2016@163.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/echoaudio')
-rw-r--r--sound/pci/echoaudio/layla24_dsp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/pci/echoaudio/layla24_dsp.c b/sound/pci/echoaudio/layla24_dsp.c
index df28e5117359..c02bc1dcc170 100644
--- a/sound/pci/echoaudio/layla24_dsp.c
+++ b/sound/pci/echoaudio/layla24_dsp.c
@@ -135,7 +135,7 @@ static int load_asic(struct echoaudio *chip)
err = load_asic_generic(chip, DSP_FNC_LOAD_LAYLA24_EXTERNAL_ASIC,
FW_LAYLA24_2S_ASIC);
if (err < 0)
- return false;
+ return err;
/* Now give the external ASIC a little time to set up */
mdelay(10);