summaryrefslogtreecommitdiff
path: root/sound/pci
diff options
context:
space:
mode:
authorWenwen Wang <wang6495@umn.edu>2019-04-27 09:06:46 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-05-22 08:39:47 +0300
commit5d981f0b09f385322737bc2eb7af627e40fe95b9 (patch)
tree7e91474697dc9a699a23df909bdab9f92de72e24 /sound/pci
parent2c37e50c717676502dfbc67c83ea721ab84b6baa (diff)
downloadlinux-5d981f0b09f385322737bc2eb7af627e40fe95b9.tar.xz
ALSA: usb-audio: Fix a memory leak bug
commit cb5173594d50c72b7bfa14113dfc5084b4d2f726 upstream. In parse_audio_selector_unit(), the string array 'namelist' is allocated through kmalloc_array(), and each string pointer in this array, i.e., 'namelist[]', is allocated through kmalloc() in the following for loop. Then, a control instance 'kctl' is created by invoking snd_ctl_new1(). If an error occurs during the creation process, the string array 'namelist', including all string pointers in the array 'namelist[]', should be freed, before the error code ENOMEM is returned. However, the current code does not free 'namelist[]', resulting in memory leaks. To fix the above issue, free all string pointers 'namelist[]' in a loop. Signed-off-by: Wenwen Wang <wang6495@umn.edu> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound/pci')
0 files changed, 0 insertions, 0 deletions