summaryrefslogtreecommitdiff
path: root/sound/pci
diff options
context:
space:
mode:
authorJiajun Cao <jjcao20@fudan.edu.cn>2021-06-22 16:19:42 +0300
committerTakashi Iwai <tiwai@suse.de>2021-06-22 17:12:03 +0300
commit8c13212443230d03ff25014514ec0d53498c0912 (patch)
tree8b0780fe81c3d502049ee0078cb10c513b9f6647 /sound/pci
parent362372ceb6556f338e230f2d90af27b47f82365a (diff)
downloadlinux-8c13212443230d03ff25014514ec0d53498c0912.tar.xz
ALSA: hda: Add IRQ check for platform_get_irq()
The function hda_tegra_first_init() neglects to check the return value after executing platform_get_irq(). hda_tegra_first_init() should check the return value (if negative error number) for errors so as to not pass a negative value to the devm_request_irq(). Fix it by adding a check for the return value irq_id. Signed-off-by: Jiajun Cao <jjcao20@fudan.edu.cn> Signed-off-by: Xin Tan <tanxin.ctf@gmail.com> Reviewed-by: Thierry Reding <treding@nvidia.com> Link: https://lore.kernel.org/r/20210622131947.94346-1-jjcao20@fudan.edu.cn Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci')
-rw-r--r--sound/pci/hda/hda_tegra.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
index 5aeef6123781..ea700395bef4 100644
--- a/sound/pci/hda/hda_tegra.c
+++ b/sound/pci/hda/hda_tegra.c
@@ -260,6 +260,9 @@ static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
const char *sname, *drv_name = "tegra-hda";
struct device_node *np = pdev->dev.of_node;
+ if (irq_id < 0)
+ return irq_id;
+
err = hda_tegra_init_chip(chip, pdev);
if (err)
return err;